🐛 fix ClustersPerDecisionGroup as optional field #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: haoqing0110 <qhao@redhat.com>
|
/assign @serngawy |
serngawy
reviewed
Aug 22, 2023
| @@ -137,7 +137,6 @@ type GroupStrategy struct { | |||
| // group SHOULD be less than ClustersPerDecisionGroup. Once the number of items exceeds the ClustersPerDecisionGroup, | |||
| // the decisionGroups will also be be divided into multiple decisionGroups with same GroupName but different GroupIndex. | |||
| // | |||
| // +kubebuilder:validation:Required | |||
There was a problem hiding this comment.
Why removing it ? we need to keep the default value 100% exist if the user did not defined the GroupStrategy. With omitempty available it will be empty string.
There was a problem hiding this comment.
Meets below error if this field is required.
➜ placement-strategy git:(master) ✗ cat placement1.yaml
# clusteradm clusterset bind global --namespace default
apiVersion: cluster.open-cluster-management.io/v1beta1
kind: Placement
metadata:
name: placement1
namespace: default
spec:
clusterSets:
- global
tolerations:
- key: cluster.open-cluster-management.io/unreachable
operator: Exists
- key: cluster.open-cluster-management.io/unavailable
operator: Exists
decisionStrategy:
groupStrategy:
decisionGroups:
- groupName: prod-canary-west
groupClusterSelector:
labelSelector:
matchExpressions:
- key: prod-canary-west
operator: Exists
- groupName: prod-canary-east
groupClusterSelector:
labelSelector:
matchExpressions:
- key: prod-canary-east
operator: Exists
➜ placement-strategy git:(master) ✗ kubectl apply -f placement1.yaml
error: error validating "placement1.yaml": error validating data: ValidationError(Placement.spec.decisionStrategy.groupStrategy): missing required field "clustersPerDecisionGroup" in io.open-cluster-management.cluster.v1beta1.Placement.spec.decisionStrategy.groupStrategy; if you choose to ignore these errors, turn validation off with --validate=false
Even remove it, since it has default value 100%
// +kubebuilder:default:="100%"
// +optional
The applied resource will still have a default value 100% generated.
After removing the Required
➜ placement-strategy git:(master) ✗ kubectl apply -f placement1.yaml
placement.cluster.open-cluster-management.io/placement1 created
➜ placement-strategy git:(master) ✗ kubectl get placement placement1 -oyaml | grep spec -A 10
spec:
clusterSets:
- global
decisionStrategy:
groupStrategy:
clustersPerDecisionGroup: 100%
decisionGroups:
- groupClusterSelector:
labelSelector:
matchExpressions:
- key: prod-canary-west
serngawy
approved these changes
Aug 22, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16, serngawy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 2e8926a
into
open-cluster-management-io:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #