🌱 refine placement helper function #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: haoqing0110 <qhao@redhat.com>
haoqing0110
force-pushed
the
br_placement-helper
branch
from
722d9d4
to
850ced0
Compare
|
/assign @qiujian16 |
qiujian16
reviewed
Aug 29, 2023
cluster/v1beta1/helpers.go
Outdated
| // ExistingClusterGroups returns the tracker's existing decision cluster names for groups listed in groupKeys. | ||
| // Return empty set when groupKeys is empty. | ||
| func (pdct *PlacementDecisionClustersTracker) ExistingClusterGroups(groupKeys []GroupKey) ([]GroupKey, map[GroupKey]sets.Set[string]) { | ||
| func (pdct *PlacementDecisionClustersTracker) ExistingClusterGroups(groupKeys []GroupKey) ClusterGroupsMap { |
There was a problem hiding this comment.
can we use ExistingClusterGroups(groupKeys ...GroupKey)?
There was a problem hiding this comment.
Have updated the code.
cluster/v1beta1/helpers.go
Outdated
| } | ||
|
|
||
| // GetClusterSets returns a set containing all clusters from all group sets. | ||
| func (g ClusterGroupsMap) GetClusterSets() sets.Set[string] { |
There was a problem hiding this comment.
ClusterSets here is confusing, GetClusters maybe
Signed-off-by: haoqing0110 <qhao@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 4fab7d4
into
open-cluster-management-io:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #