-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 refine placement helper function #270
🌱 refine placement helper function #270
Conversation
Signed-off-by: haoqing0110 <qhao@redhat.com>
722d9d4
to
850ced0
Compare
/assign @qiujian16 |
cluster/v1beta1/helpers.go
Outdated
// ExistingClusterGroups returns the tracker's existing decision cluster names for groups listed in groupKeys. | ||
// Return empty set when groupKeys is empty. | ||
func (pdct *PlacementDecisionClustersTracker) ExistingClusterGroups(groupKeys []GroupKey) ([]GroupKey, map[GroupKey]sets.Set[string]) { | ||
func (pdct *PlacementDecisionClustersTracker) ExistingClusterGroups(groupKeys []GroupKey) ClusterGroupsMap { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use ExistingClusterGroups(groupKeys ...GroupKey)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have updated the code.
cluster/v1beta1/helpers.go
Outdated
} | ||
|
||
// GetClusterSets returns a set containing all clusters from all group sets. | ||
func (g ClusterGroupsMap) GetClusterSets() sets.Set[string] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ClusterSets here is confusing, GetClusters maybe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Signed-off-by: haoqing0110 <qhao@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4fab7d4
into
open-cluster-management-io:main
Summary
Related issue(s)
Fixes #