Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add Ignore rollout status #272

Closed
wants to merge 2 commits into from

Conversation

dhaiducek
Copy link
Member

Summary

An Ignore rollout status in my reading of it felt different than a Skip status, where Ignore would mean that it wouldn't factor into a rollout but would receive updates while Skip would mean it didn't receive updates, but I'm open to discussion on it.

I also have an optional commit here to add RolloutType to make the enum a bit more concrete.

Related issue(s)

Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
@dhaiducek
Copy link
Member Author

/cc @mprahl

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dhaiducek
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member

/assign @haoqing0110

@haoqing0110
Copy link
Member

haoqing0110 commented Sep 1, 2023

For the skip status, when adding it, expect it to be a status return from ClusterRolloutStatusFunc by API consumers, indicating that the consumers do not want to do a rollout on this cluster.
For the ignore status, not sure what does "receive updates" mean? in the PR seems ingore returns the same value as skip.

@dhaiducek
Copy link
Member Author

dhaiducek commented Sep 2, 2023

/hold

For the skip status, when adding it, expect it to be a status return from ClusterRolloutStatusFunc by API consumers, indicating that the consumers do not want to do a rollout on this cluster. For the ignore status, not sure what does "receive updates" mean? in the PR seems ingore returns the same value as skip.

Thanks for the feedback. We want users to be able to specify that a particular cluster should get updated in the rollout but it doesn't matter to them whether the status is returned successful. It seems adding Ignore is confusing, so we're going to consider this further. For this it seems like we should just use Succeeded if it succeeds but add a FailedNonBlocking status instead of Ignore to say that the library is aware it failed during the rollout but is continuing on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants