-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ integration test for cloudevents clients #275
✨ integration test for cloudevents clients #275
Conversation
e2fdc0b
to
30111ff
Compare
/assign @qiujian16 |
/assign @morvencao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall
/LGTM
} | ||
|
||
func (s *memoryStore) Get(resourceID string) (*Resource, error) { | ||
s.Lock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: use s.RLock()
and s.RUnlock()
for read operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
cloudevents/README.md
Outdated
4. Codecs (`generic.Codec`), they are used to encode a resource object into a cloudevent and decode a cloudevent into a | ||
resource object with a given cloudevent data type. We have provided two data type (`io.open-cluster-management.works.v1alpha1.manifests` | ||
and `io.open-cluster-management.works.v1alpha1.manifestbundles`) for `ManifestWork`, they can be found in the `work/payload` | ||
package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it would be better to add more description about how the event data type mapping to the cloudevent payload format.
For example:
For the io.open-cluster-management.works.v1alpha1.manifests
data type, the cloud event payload contains a single resource object, while for io.open-cluster-management.works.v1alpha1.manifestbundles
, it contains a list of resource objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
30111ff
to
eb87d48
Compare
can we set it as a separated integration test? the other integration test is mainly on api validation |
eb87d48
to
db65aeb
Compare
separate to and with separated make task |
db65aeb
to
0c3d102
Compare
I would suggest put it in the separated github action. It is easier to debug |
e54d5e2
to
45eade8
Compare
Signed-off-by: Wei Liu <liuweixa@redhat.com>
7b25c00
to
1811d53
Compare
done |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, skeeey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
886b462
into
open-cluster-management-io:main
Summary
integration test for cloudevents clients