-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 rename placement decision tracker get function #278
🌱 rename placement decision tracker get function #278
Conversation
f6e221b
to
acf8362
Compare
/assign @qiujian16 |
cluster/v1beta1/helpers.go
Outdated
// Get updates the tracker's decisionClusters and returns added and deleted cluster names. | ||
func (pdct *PlacementDecisionClustersTracker) Get() (sets.Set[string], sets.Set[string], error) { | ||
// UpdateClusters updates the tracker's decisionClusters. | ||
func (pdct *PlacementDecisionClustersTracker) UpdateClusters() error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will Update or Refresh better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to refresh, sounds better.
acf8362
to
189ddaa
Compare
Signed-off-by: haoqing0110 <qhao@redhat.com>
189ddaa
to
94c3fb7
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ad02e82
into
open-cluster-management-io:main
Summary
Rename Get() to GetClusterChanges() and add function UpdateClusters() to update the existing clusters.
Related issue(s)
Fixes #