🌱 rename placement decision tracker get function #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqing0110
changed the title
haoqing0110
force-pushed
the
br_pdtracker
branch
from
f6e221b
to
acf8362
Compare
|
/assign @qiujian16 |
qiujian16
reviewed
Sep 13, 2023
cluster/v1beta1/helpers.go
Outdated
| // Get updates the tracker's decisionClusters and returns added and deleted cluster names. | ||
| func (pdct *PlacementDecisionClustersTracker) Get() (sets.Set[string], sets.Set[string], error) { | ||
| // UpdateClusters updates the tracker's decisionClusters. | ||
| func (pdct *PlacementDecisionClustersTracker) UpdateClusters() error { |
There was a problem hiding this comment.
Will Update or Refresh better?
There was a problem hiding this comment.
Rename to refresh, sounds better.
haoqing0110
force-pushed
the
br_pdtracker
branch
from
acf8362
to
189ddaa
Compare
Signed-off-by: haoqing0110 <qhao@redhat.com>
haoqing0110
force-pushed
the
br_pdtracker
branch
from
189ddaa
to
94c3fb7
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit ad02e82
into
open-cluster-management-io:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rename Get() to GetClusterChanges() and add function UpdateClusters() to update the existing clusters.
Related issue(s)
Fixes #