-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Replace Timeout
with RolloutConfig
#281
✨ Replace Timeout
with RolloutConfig
#281
Conversation
@dhaiducek since we are about to release 0.12.0, would like to know the progress of this PR. Is it ready for review, do you plan to include it in 0.12.0 or it can be moved to next release? |
@qiujian16 It was waiting on #276, but now that it's merged I'll continue work here. I'll work on it this week, but I think it's also fine if |
5477613
to
4d738a1
Compare
8ae66b2
to
d35c1f5
Compare
Status update: I wrestled with the CI a bit because I'm on an M1 MacBook and some of the binaries aren't actually built for arm64 (those changes are in this PR). I've got current code working, migrating |
d35c1f5
to
c04c9d8
Compare
Timeout
with RolloutConfig
Timeout
with RolloutConfig
Sorry for the long delay here--between wrestling with the CI and getting pulled away for other tasks, it's taken longer to update than I thought. There might be some more tests required here, but I think the logic is largely (if not entirely) there. Some notes:
|
c04c9d8
to
c9fd8e3
Compare
Sounds good to me in general, I added more unit test to cover Rollout ProgressivePerGroup case. |
5939ab2
to
9b6bf27
Compare
After discussion with @serngawy I've updated the logic so that |
LGTM, seems the |
9b6bf27
to
de4a95b
Compare
Uses `MinSuccessTime`, `ProgressDeadline`, and `MaxFailures` for a more fine-tuned configuration. Also passes `Timeout` over to `ProgressDeadline` and marks it as deprecated. Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Signed-off-by: melserngawy <melserng@redhat.com>
- MandatoryDecisionGroups should tolerate no failures - The logic for ProgressivePerGroup was incorrect Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
de4a95b
to
9b88aa5
Compare
/approve Since manifestworkReplicaSet and ClusterManagerAddon install strategy is in alpha stage. Let's remove timeout in the next release (ie 0.14.0) |
Sounds good, thanks @qiujian16! @serngawy @haoqing0110 I'd appreciate if you'd do another review here when you have a moment! 😄 |
I gave it another review, sounds good to me @dhaiducek appreciate the good work :) ops, didn't consider my approve will merge it @haoqing0110 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, qiujian16, serngawy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c10ed7e
into
open-cluster-management-io:main
Summary
Implement
RolloutConfig
, which provides more fine-tuned configuration for users than the currentTimeout
.Related issue(s)