Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix some concurrent problems #294

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

skeeey
Copy link
Member

@skeeey skeeey commented Nov 9, 2023

Summary

fix some concurrent problems

  1. Ensure the user properties are independent for each event (see Clean up the previous user properties from MQTT protocol  cloudevents/sdk-go#935)
  2. Ensure parallel writes are thread-Safe for mqtt client

Signed-off-by: Wei Liu <liuweixa@redhat.com>
@skeeey
Copy link
Member Author

skeeey commented Nov 9, 2023

/assign @qiujian16

@qiujian16
Copy link
Member

ha, this is tricky
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 9, 2023
Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, skeeey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 9, 2023
@openshift-ci openshift-ci bot merged commit 2fea4c2 into open-cluster-management-io:main Nov 9, 2023
15 checks passed
@skeeey skeeey deleted the cloudevent-cc branch January 17, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants