🌱 separate the clientid and sourceid for mqtt source client #305
Conversation
|
/assign @qiujian16 |
|
/cc @morvencao |
| } | ||
|
|
||
| func NewSourceOptions(mqttOptions *MQTTOptions, sourceID string) *options.CloudEventsSourceOptions { | ||
| func NewSourceOptions(mqttOptions *MQTTOptions, clientID, sourceID string) *options.CloudEventsSourceOptions { | ||
| return &options.CloudEventsSourceOptions{ | ||
| CloudEventsOptions: &mqttSourceOptions{ | ||
| MQTTOptions: *mqttOptions, | ||
| errorChan: make(chan error), | ||
| sourceID: sourceID, |
There was a problem hiding this comment.
why do we still need source id here, or the one in line 32?
There was a problem hiding this comment.
this is used to build the CloudEventsSourceOptions, the line 29 is for the mqttSourceOptions, we use it to build mqtt client (topic), and the line 32 is for the CloudEventsSourceOptions
There was a problem hiding this comment.
reorg the code, make this more clear
Signed-off-by: Wei Liu <liuweixa@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, skeeey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 66fe32e
into
open-cluster-management-io:main
Summary
Related issue(s)
Fixes #