-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 remove timeout field in rolloutstrategy v1alpha1 #309
🌱 remove timeout field in rolloutstrategy v1alpha1 #309
Conversation
/assign @qiujian16 |
@@ -64,6 +64,8 @@ type RolloutConfig struct { | |||
MinSuccessTime metav1.Duration `json:"minSuccessTime,omitempty"` | |||
// ProgressDeadline defines how long workload applier controller will wait for the workload to | |||
// reach a successful state in the cluster. | |||
// If the workload does not reach a successful state after ProgressDeadline, will stop waiting | |||
// and proceed to next rollout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it also depend on max failure. Actuall it will stop rolling unless maxFailure is larger than 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have updated the comments.
cluster/v1alpha1/helpers.go
Outdated
@@ -293,6 +293,9 @@ func progressivePerCluster( | |||
|
|||
// If there was a breach of MaxFailures, only handle clusters that have already had workload applied | |||
if !failureBreach || failureBreach && status.Status != ToApply { | |||
// The length of `rolloutClusters` will be compared with the target rollout size to determine whether to return or not. | |||
// The `timeoutClusters` only records clusters that are timeout and is not used for comparison with the target rollout size. | |||
// In other words, the timeouted clusters are skipped and continue rollout on other clusters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depend on whether failure exceeds maxfailures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have updated the comments.
Signed-off-by: haoqing0110 <qhao@redhat.com>
af6d56c
to
f2e7243
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ccd7a2d
into
open-cluster-management-io:main
Summary
Timeout is duplicated with ProgressDeadline, remove and use ProgressDeadline instead.
Related issue(s)
Fixes #