-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add QPS and burst for the agent components #311
✨ add QPS and burst for the agent components #311
Conversation
c79ec22
to
279a63b
Compare
279a63b
to
f808fbd
Compare
f808fbd
to
e83ade8
Compare
operator/v1/types_clustermanager.go
Outdated
// FlagOptions represents a list of flag options for the component binary. | ||
// The key is the option name, the value is the option value. | ||
// The FlagOptions can override all configured options including the default options and FeatureGates, etc. | ||
// +optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set this to listMap
operator/v1/types_klusterlet.go
Outdated
// +optional | ||
// +kubebuilder:default:=50 | ||
// +kubebuilder:validation:Pattern=^(-?\d+)(.\d+)?$ | ||
KubeAPIQPS string `json:"qps,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the json field should be also kubeAPIQPS, why it is not int32 with max?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to kubeAPIQPS. the QPS is float, but float is not suggested to be used in API, so use string here and added a validation.
13abe19
to
7ec86d7
Compare
Signed-off-by: ZhiweiYin <zyin@redhat.com>
7ec86d7
to
ef2c60e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3d94ce8
into
open-cluster-management-io:main
Summary
Related issue(s)
Fixes #