✨ add QPS and burst for the agent components #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiujian16
reviewed
Jan 10, 2024
zhiweiyin318
force-pushed
the
add-flag
branch
2 times, most recently
from
c79ec22
to
279a63b
Compare
qiujian16
reviewed
Jan 10, 2024
qiujian16
reviewed
Jan 10, 2024
zhiweiyin318
force-pushed
the
add-flag
branch
from
279a63b
to
f808fbd
Compare
zhiweiyin318
changed the title
zhiweiyin318
force-pushed
the
add-flag
branch
from
f808fbd
to
e83ade8
Compare
qiujian16
reviewed
Jan 11, 2024
operator/v1/types_clustermanager.go
Outdated
| // FlagOptions represents a list of flag options for the component binary. | ||
| // The key is the option name, the value is the option value. | ||
| // The FlagOptions can override all configured options including the default options and FeatureGates, etc. | ||
| // +optional |
operator/v1/types_klusterlet.go
Outdated
| // +optional | ||
| // +kubebuilder:default:=50 | ||
| // +kubebuilder:validation:Pattern=^(-?\d+)(.\d+)?$ | ||
| KubeAPIQPS string `json:"qps,omitempty"` |
There was a problem hiding this comment.
the json field should be also kubeAPIQPS, why it is not int32 with max?
There was a problem hiding this comment.
changed to kubeAPIQPS. the QPS is float, but float is not suggested to be used in API, so use string here and added a validation.
zhiweiyin318
force-pushed
the
add-flag
branch
2 times, most recently
from
13abe19
to
7ec86d7
Compare
Signed-off-by: ZhiweiYin <zyin@redhat.com>
zhiweiyin318
force-pushed
the
add-flag
branch
from
7ec86d7
to
ef2c60e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3d94ce8
into
open-cluster-management-io:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #