🌱 Regenerate informers with WithTransform #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
Can we get review on this? This will be very helpful for optimization work we're doing on SubmarinerAddon. |
|
/assign @qiujian16 |
|
would you run go mod tidy and go mod vendor? |
Since 1.29, Kubernetes supports transforming informers, which is useful to reduce the amount of memory used by the underlying caches. This updates the code generator to the latest 0.29 release and re-generates the informers. This requires upgrading to Go 1.21. Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
force-pushed
the
transform-informers
branch
from
8176c97
to
96ca0a5
Compare
I’d already done that, the verify-deps failure happened because CI was set up for Go 1.20 and the build now requires 1.21. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, skitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 29e1b1d
into
open-cluster-management-io:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since 1.29, Kubernetes supports transforming informers, which is useful to reduce the amount of memory used by the underlying caches. This updates the code generator to the latest 0.29 release and re-generates the informers.
Related issue(s)
Fixes #