-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 add condition and reason definition in operator #325
🌱 add condition and reason definition in operator #325
Conversation
4300319
to
2b62244
Compare
operator/v1/types_klusterlet.go
Outdated
// ReasonManagementClusterResourceApplyFailed is the reason of ConditionKlusterletApplied condition failed to apply resources on management cluster. | ||
ReasonManagementClusterResourceApplyFailed = "ManagementClusterResourceApplyFailed" | ||
|
||
// ReasonKlusterletPrepareFailed is the reason of ConditionReadyToApply condition to show failed to prepare before apply/delete resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does prepare mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prepare means to get kubeconfig in external-managed-kubeconfig secret successfully
changed to :
ReasonKlusterletPrepareFailed is the reason of ConditionReadyToApply condition to show it is failed to get the kubeConfig of managed cluster from the external-managed-kubeconfig secret in the hosted mode.
ReasonKlusterletPrepared is the reason of ConditionReadyToApply condition to show the kubeConfig of managed cluster is validated from the external-managed-kubeconfig secret in the hosted mode.
7de8ca7
to
46b2dad
Compare
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
46b2dad
to
ab5396a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8f6aa25
into
open-cluster-management-io:main
Summary
move the condition and reason definitions of operator here.
Related issue(s)
Fixes #