-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 add cloudevents driver feature gate for manifestwork replicaset. #326
🌱 add cloudevents driver feature gate for manifestwork replicaset. #326
Conversation
Signed-off-by: morvencao <lcao@redhat.com>
feature/feature.go
Outdated
@@ -64,6 +64,10 @@ const ( | |||
// of clusters selected by a placement. For more info check ManifestWorkReplicaSet APIs | |||
ManifestWorkReplicaSet featuregate.Feature = "ManifestWorkReplicaSet" | |||
|
|||
// ManifestWorkReplicaSetCloudEventsDrivers will enable the cloud events drivers (mqtt or grpc) for the | |||
// ManifestWorkReplicaSet controller, so that the controller can send manifestworks through cloud events. | |||
ManifestWorkReplicaSetCloudEventsDrivers featuregate.Feature = "ManifestWorkReplicaSetCloudEventsDrivers" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be just CloudEventsDrivers. addon manager might need to pick this featuregate also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated name to CloudEventsDrivers
.
Signed-off-by: morvencao <lcao@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: morvencao, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aacb530
into
open-cluster-management-io:main
Summary
This PR tries to add new feature gate to control whether cloudevents driver is enabled for manifestworkreplicaset controlller.
Related issue(s)
open-cluster-management-io/ocm#381