🌱 add cloudevents driver feature gate for manifestwork replicaset. #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: morvencao <lcao@redhat.com>
qiujian16
reviewed
Apr 19, 2024
feature/feature.go
Outdated
| @@ -64,6 +64,10 @@ const ( | |||
| // of clusters selected by a placement. For more info check ManifestWorkReplicaSet APIs | |||
| ManifestWorkReplicaSet featuregate.Feature = "ManifestWorkReplicaSet" | |||
|
|
|||
| // ManifestWorkReplicaSetCloudEventsDrivers will enable the cloud events drivers (mqtt or grpc) for the | |||
| // ManifestWorkReplicaSet controller, so that the controller can send manifestworks through cloud events. | |||
| ManifestWorkReplicaSetCloudEventsDrivers featuregate.Feature = "ManifestWorkReplicaSetCloudEventsDrivers" | |||
There was a problem hiding this comment.
might be just CloudEventsDrivers. addon manager might need to pick this featuregate also.
There was a problem hiding this comment.
updated name to CloudEventsDrivers.
Signed-off-by: morvencao <lcao@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: morvencao, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit aacb530
into
open-cluster-management-io:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR tries to add new feature gate to control whether cloudevents driver is enabled for manifestworkreplicaset controlller.
Related issue(s)
open-cluster-management-io/ocm#381