✨ add AppliedManifestWorkEvictionGracePeriod in klusterlet #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Le <yangle@redhat.com>
qiujian16
reviewed
Apr 29, 2024
| // evicting the AppliedManifestWorks, whose corresponding ManifestWorks are missing on the hub cluster, from | ||
| // the managed cluster. If not present, the default value of the work agent will be used. | ||
| // +optional | ||
| // +kubebuilder:validation:Type=string |
There was a problem hiding this comment.
Nil means the appliedManifestWorkEvictionGracePeriod is not specified. The default value of the work agent will be used.
There was a problem hiding this comment.
If a struct is used instead of a pointer, an empty struct will result in a zero value of the appliedManifestWorkEvictionGracePeriod.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elgnay, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e247553
into
open-cluster-management-io:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #