✨ Add MultipleHubs in the feature gate list.
#331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @qiujian16 |
qiujian16
reviewed
May 21, 2024
feature/feature.go
Outdated
| @@ -74,6 +74,9 @@ const ( | |||
|
|
|||
| // ResourceCleanup will start gc controller to clean up resources in cluster ns after cluster is deleted. | |||
| ResourceCleanup featuregate.Feature = "ResourceCleanup" | |||
|
|
|||
| // SwitchHub allows user to configure multiple bootstrapkubeconfig via Klusterlet and let agent to decide which one to use | |||
| SwitchHub featuregate.Feature = "SwitchHub" | |||
There was a problem hiding this comment.
MultipleHubs might be a better name. Thought @elgnay ?
There was a problem hiding this comment.
Agree, the MultipleHubs is better, fixed.
xuezhaojun
force-pushed
the
add-switch-hub-in-feature-gate
branch
from
f39df3e
to
49cb79e
Compare
xuezhaojun
changed the title
MultipleHubs in the feature gate list.
qiujian16
reviewed
May 21, 2024
feature/feature.go
Outdated
| @@ -74,6 +74,9 @@ const ( | |||
|
|
|||
| // ResourceCleanup will start gc controller to clean up resources in cluster ns after cluster is deleted. | |||
| ResourceCleanup featuregate.Feature = "ResourceCleanup" | |||
|
|
|||
| // MultipleHubs allows user to configure multiple bootstrapkubeconfig via Klusterlet and let agent to decide which one to use | |||
There was a problem hiding this comment.
Suggested change
| // MultipleHubs allows user to configure multiple bootstrapkubeconfig via Klusterlet and let agent to decide which one to use | |
| // MultipleHubs allows user to configure multiple bootstrapkubeconfig connecting to different hubs via Klusterlet and let agent decide which one to use |
Signed-off-by: xuezhaojun <zxue@redhat.com>
xuezhaojun
force-pushed
the
add-switch-hub-in-feature-gate
branch
from
49cb79e
to
dceddca
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 9d94703
into
open-cluster-management-io:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
MultipleHubsis in alpha stage, is used by both operator and registration-agent.