-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add MultipleHubs
in the feature gate list.
#331
✨ Add MultipleHubs
in the feature gate list.
#331
Conversation
/assign @qiujian16 |
feature/feature.go
Outdated
@@ -74,6 +74,9 @@ const ( | |||
|
|||
// ResourceCleanup will start gc controller to clean up resources in cluster ns after cluster is deleted. | |||
ResourceCleanup featuregate.Feature = "ResourceCleanup" | |||
|
|||
// SwitchHub allows user to configure multiple bootstrapkubeconfig via Klusterlet and let agent to decide which one to use | |||
SwitchHub featuregate.Feature = "SwitchHub" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MultipleHubs might be a better name. Thought @elgnay ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, the MultipleHubs
is better, fixed.
f39df3e
to
49cb79e
Compare
MultipleHubs
in the feature gate list.
feature/feature.go
Outdated
@@ -74,6 +74,9 @@ const ( | |||
|
|||
// ResourceCleanup will start gc controller to clean up resources in cluster ns after cluster is deleted. | |||
ResourceCleanup featuregate.Feature = "ResourceCleanup" | |||
|
|||
// MultipleHubs allows user to configure multiple bootstrapkubeconfig via Klusterlet and let agent to decide which one to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// MultipleHubs allows user to configure multiple bootstrapkubeconfig via Klusterlet and let agent to decide which one to use | |
// MultipleHubs allows user to configure multiple bootstrapkubeconfig connecting to different hubs via Klusterlet and let agent decide which one to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Signed-off-by: xuezhaojun <zxue@redhat.com>
49cb79e
to
dceddca
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9d94703
into
open-cluster-management-io:main
Summary
The
MultipleHubs
is in alpha stage, is used by both operator and registration-agent.