-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ ReadOnly type in work #332
✨ ReadOnly type in work #332
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/hold |
@@ -189,6 +190,11 @@ const ( | |||
// If there is conflict, the related Applied condition of manifest will be in the status of False with the | |||
// reason of ApplyConflict. This type allows another controller on the spoke to control certain field of the resource. | |||
UpdateStrategyTypeServerSideApply UpdateStrategyType = "ServerSideApply" | |||
|
|||
// UpdateStrategyTypeReadOnly type means only check the existence of the resource based on the resource's metadata. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May update others to use field name in the comment instead of the value. for example: UpdateStrategyTypeServerSideApply
type means to update resource.
Signed-off-by: Jian Qiu <jqiu@redhat.com>
/lgtm |
LGTM |
/unhold |
bda2bdc
into
open-cluster-management-io:main
Summary
Related issue(s)
Fixes #