Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 code-generator 0.29.5 doesn't nuke files #333

Conversation

skitt
Copy link
Contributor

@skitt skitt commented May 28, 2024

Summary

This file removal bug was fixed by
kubernetes/kubernetes#123261
so the workaround can be removed.

@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 May 28, 2024 15:55
This file removal bug was fixed by
kubernetes/kubernetes#123261
so the workaround can be removed.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@skitt skitt changed the title code-generator 0.29.5 doesn't nuke files 🌱 code-generator 0.29.5 doesn't nuke files May 28, 2024
@qiujian16
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cf2d921 into open-cluster-management-io:main May 29, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants