-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add regex validation for signer #336
🐛 Add regex validation for signer #336
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold /assign @zhujian7 |
7a6ab75
to
cb65c0d
Compare
/unhold |
Signed-off-by: Jian Qiu <jqiu@redhat.com>
cb65c0d
to
d8ab760
Compare
@@ -314,6 +314,7 @@ spec: | |||
will use to create csr. | |||
maxLength: 571 | |||
minLength: 5 | |||
pattern: ^([a-z0-9][a-z0-9-]+\.)+[a-z]+\/[a-z0-9-\.]+$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pattern: ^([a-z0-9][a-z0-9-]+\.)+[a-z]+\/[a-z0-9-\.]+$ | |
pattern: ^([a-z0-9][a-z0-9-]*\.)+[a-z]+\/[a-z0-9-\.]+$ |
Signed-off-by: Jian Qiu <jqiu@redhat.com>
523e378
to
905e28e
Compare
/lgtm |
60a6d04
into
open-cluster-management-io:main
Summary
Related issue(s)
Fixes open-cluster-management-io/ocm#382