Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove argocd api dependency #18

Conversation

mikeshng
Copy link
Member

  • Removed the Argo CD API dependency from the repo
  • Bring all the dependencies up to date.

Tested and it seems fine 2024-11-14T03:49:34Z INFO setup starting manager with unstructured Application

Copy link

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikeshng mikeshng force-pushed the remove-argocd-api-dependency branch from 46da8b8 to 34c3e8a Compare November 14, 2024 04:02
Signed-off-by: Mike Ng <ming@redhat.com>
@mikeshng mikeshng force-pushed the remove-argocd-api-dependency branch from 34c3e8a to ee98034 Compare November 14, 2024 04:04
@mikeshng
Copy link
Member Author

@xiangjingli PTAL Thanks!

This is the upstream community staging repo for the argocd pull model propagation controller. It's not directly linked to the multicloud integration repo in ocm-io or stolostron.

This might be the perfect repo for you to POC with the Maestro integration because it's nicely independent from Search API, GitOpsCluster and all the other multicloud-integration stuffs. I've already updated all the dependencies in this PR and if you look at the new go.mod file, you can see that it's quite clean. Hope that it helps.

As for the ACM issue regarding outdated argocd api, once you think this PR is merged. I will start bringing the changes over to the multicloud integration repo.

@xiangjingli
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 339170f into open-cluster-management-io:main Nov 14, 2024
5 checks passed
@mikeshng mikeshng deleted the remove-argocd-api-dependency branch November 14, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants