Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go.mod open-cluster-management.io api. #167

Conversation

xuezhaojun
Copy link
Member

@xuezhaojun xuezhaojun commented Sep 5, 2023

@openshift-ci
Copy link

openshift-ci bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xuezhaojun
Copy link
Member Author

/assign @haoqing0110

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 71.42% and no project coverage change.

Comparison is base (366272a) 23.31% compared to head (9c80fdb) 23.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   23.31%   23.31%           
=======================================
  Files           9        9           
  Lines        1175     1175           
=======================================
  Hits          274      274           
  Misses        885      885           
  Partials       16       16           
Flag Coverage Δ
unit 23.31% <71.42%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...yserver/controllers/service_resolver_controller.go 0.00% <0.00%> (ø)
pkg/proxyagent/agent/agent.go 88.59% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoqing0110
Copy link
Member

haoqing0110 commented Sep 5, 2023

@xuezhaojun xuezhaojun force-pushed the upgrade-gomod-ocm-api branch from 4ce1549 to 5d59b29 Compare September 5, 2023 07:01
@xuezhaojun xuezhaojun closed this Sep 5, 2023
@xuezhaojun xuezhaojun reopened this Sep 5, 2023
Signed-off-by: xuezhaojun <zxue@redhat.com>
@xuezhaojun xuezhaojun force-pushed the upgrade-gomod-ocm-api branch from 5d59b29 to 9c80fdb Compare September 5, 2023 07:29
@haoqing0110
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit f2cfda4 into open-cluster-management-io:main Sep 5, 2023
8 checks passed
@xuezhaojun xuezhaojun deleted the upgrade-gomod-ocm-api branch March 7, 2024 02:13
xuezhaojun added a commit to xuezhaojun/cluster-proxy that referenced this pull request Dec 2, 2024
…n-add-approver

Add zhujian7 as approver in .tekton/OWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants