allow install regiatration agent using multicluster controlplane in join command #338
Conversation
ycyaoxdu
changed the title
ycyaoxdu
force-pushed
the
allow-join-controlplane-agent
branch
from
36be8c4 to
e2e6c62
Compare
ycyaoxdu
changed the title
pkg/cmd/join/cmd.go
Outdated
| _ = klusterletSet.SetAnnotation("managed-cluster-kubeconfig", "mode-orinted", []string{"hosted"}) | ||
|
|
||
| //controlplaneAgentSet contains the flags for deploy controlplane agent | ||
| controlplaneAgentSet := pflag.NewFlagSet("controlplane-agent", pflag.ExitOnError) |
There was a problem hiding this comment.
controlplane-agent is confusing. I would use standalone
ycyaoxdu
force-pushed
the
allow-join-controlplane-agent
branch
2 times, most recently
from
9ba43ea to
4d895bd
Compare
pkg/cmd/join/cmd.go
Outdated
| @@ -62,5 +62,7 @@ func NewCmd(clusteradmFlags *genericclioptionsclusteradm.ClusteradmFlags, stream | |||
| cmd.Flags().BoolVar(&o.wait, "wait", false, "If true, running the cluster registration in foreground.") | |||
| cmd.Flags().StringVarP(&o.mode, "mode", "m", "default", "mode to deploy klusterlet, can be default or hosted") | |||
| cmd.Flags().StringVar(&o.managedKubeconfigFile, "managed-cluster-kubeconfig", "", "To specify the directory to external managed cluster kubeconfig in hosted mode") | |||
| cmd.Flags().BoolVar(&o.standalone, "standalone", false, "If true, deploy standalone controlplane agent instead of klusterlet") | |||
There was a problem hiding this comment.
we should put a note here indicate it is still a feature in alpha stage
There was a problem hiding this comment.
we should not call at as standalone. it is misleading. maybe we just use multicluster-controlplane instead.
There was a problem hiding this comment.
IMHO, it is hard to understand what is multicluster-controlplane. It is a project name rather than how we deploy the agent. And in the long term, we probably will build the standalone agent directly from the ocm repo.
pkg/cmd/join/exec.go
Outdated
| files = append(files, | ||
| "join/hosted/external_managed_kubeconfig.yaml", | ||
| "standalone/bootstrap_hub_kubeconfig.yaml", |
There was a problem hiding this comment.
why this is different from the one for join command?
ycyaoxdu
force-pushed
the
allow-join-controlplane-agent
branch
4 times, most recently
from
ebde4a8 to
b41b580
Compare
ycyaoxdu
force-pushed
the
allow-join-controlplane-agent
branch
4 times, most recently
from
366ca18 to
84caac2
Compare
Signed-off-by: yuchenyao <yaoyuchen0626@163.com>
ycyaoxdu
force-pushed
the
allow-join-controlplane-agent
branch
from
84caac2 to
0e3a500
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, ycyaoxdu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.