Fix: using deprecated field AddOnConfiguiration causing proxy health not work.
#348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuezhaojun
force-pushed
the
fix-cluster-proxy-addon-health-check
branch
from
4483ff0
to
3a126b8
Compare
xuezhaojun
commented
Jun 19, 2023
pkg/cmd/proxy/health/exec.go
Outdated
| proxyConfig, err := proxyClient.ProxyV1alpha1().ManagedProxyConfigurations(). | ||
| Get(context.TODO(), clusterAddon.Spec.AddOnConfiguration.CRName, metav1.GetOptions{}) | ||
| Get(context.TODO(), "cluster-proxy", metav1.GetOptions{}) |
There was a problem hiding this comment.
The name of managedproxyconfiguration is always cluster-proxy if we deploy addon via clusteradm: https://github.com/open-cluster-management-io/cluster-proxy/blob/2a197b382114b674b76a362146a7259aed164424/charts/cluster-proxy/templates/managedproxyconfiguration.yaml#L4
|
/assign @qiujian16 |
xuezhaojun
force-pushed
the
fix-cluster-proxy-addon-health-check
branch
2 times, most recently
from
0dc91b7
to
02188d8
Compare
qiujian16
reviewed
Jun 19, 2023
pkg/cmd/proxy/health/exec.go
Outdated
| proxyConfig, err := proxyClient.ProxyV1alpha1().ManagedProxyConfigurations(). | ||
| Get(context.TODO(), clusterAddon.Spec.AddOnConfiguration.CRName, metav1.GetOptions{}) | ||
| Get(context.TODO(), "cluster-proxy", metav1.GetOptions{}) |
xuezhaojun
force-pushed
the
fix-cluster-proxy-addon-health-check
branch
from
02188d8
to
56ead55
Compare
…th` not work. Signed-off-by: xuezhaojun <zxue@redhat.com>
xuezhaojun
force-pushed
the
fix-cluster-proxy-addon-health-check
branch
from
56ead55
to
5a69366
Compare
|
/assign @qiujian16 Rebase, PTAL, thanks! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit b254f69
into
open-cluster-management-io:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #347