Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update integration tests #408

Conversation

dhaiducek
Copy link
Member

@dhaiducek dhaiducek commented Mar 29, 2024

Summary

  • Add a pre-flight test run in the release workflow that sets the bundle version for the integration tests (and could be used in other tests as well)
  • Use the ginkgo CLI to run tests (I find the output a bit cleaner since our tests are written with Ginkgo)
  • Refactors the addon integration tests, making it a bit easier to maintain and also add an addon in the future, also adding a deployment readiness check.

Related issue(s)

Fixes #

The output is much clearer

Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
@dhaiducek
Copy link
Member Author

/cc @mikeshng

@openshift-ci openshift-ci bot requested a review from mikeshng March 29, 2024 17:17
@dhaiducek
Copy link
Member Author

/cc @qiujian16

@openshift-ci openshift-ci bot requested a review from qiujian16 March 29, 2024 17:19
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/assign @zhujian7

Copy link

openshift-ci bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 1, 2024
This will make adding addon tests in the future
much more straightforward.

Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
@zhujian7
Copy link
Member

zhujian7 commented Apr 2, 2024

LGTM

@zhujian7
Copy link
Member

zhujian7 commented Apr 2, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 41a5ed4 into open-cluster-management-io:main Apr 2, 2024
9 checks passed
@dhaiducek dhaiducek deleted the update-integration-tests branch April 12, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants