✨ Check if there any managed clusters exists before hub cleanup #431
Conversation
Signed-off-by: Rokibul Hasan <mdrokibulhasan@appscode.com>
RokibulHasan7
changed the title
RokibulHasan7
changed the title
|
/ok-to-test |
|
@RokibulHasan7: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Signed-off-by: Rokibul Hasan <mdrokibulhasan@appscode.com>
|
/lgtm |
Signed-off-by: Rokibul Hasan <mdrokibulhasan@appscode.com>
Signed-off-by: Rokibul Hasan <mdrokibulhasan@appscode.com>
|
/approve |
Signed-off-by: Rokibul Hasan <mdrokibulhasan@appscode.com>
RokibulHasan7
force-pushed
the
validate-hub-cleanup
branch
from
bce4575
to
9131cab
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, RokibulHasan7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 6267edc
into
open-cluster-management-io:main
Summary
If any managed clusters exist,
clusteradm cleanhangs for some time and then returns 'cluster manager still exists'. Therefore, we should check if any managed clusters exist before waiting for the hub cleanup and return the proper message.Related issue(s)
Fixes #