Update the error to detect when the server only has v1beta1 CRDs #107
Conversation
It's unclear what package upgrade prompted this change, however, the existing error detection no longer worked when running on OpenShift 3.11. Relates: https://issues.redhat.com/browse/ACM-9533 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
There was a problem hiding this comment.
FWIW, it was added in controller-runtime v0.16.2. 🙂
Release: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.2
PR: kubernetes-sigs/controller-runtime#2492
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 68b2b6b
into
open-cluster-management-io:main
Ah, nice find! |
It's unclear what package upgrade prompted this change, however, the existing error detection no longer worked when running on OpenShift 3.11.
For further context, this is the error this is now detecting:
https://github.com/kubernetes-sigs/controller-runtime/blob/6747c42ce33966b0e77cac278c6b9087cc2f51c7/pkg/client/apiutil/restmapper.go#L189-L194
Relates:
https://issues.redhat.com/browse/ACM-9533