Trigger status-sync reconciles when spec-sync sees mismatching status #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaiducek
reviewed
Jul 1, 2024
dhaiducek
previously approved these changes
Jul 1, 2024
Since status-sync watches the managed cluster's replicated policies on the managed cluster (not the hub), it has a blind spot for when the hub's status doesn't match and nothing triggers a status-sync reconcile (e.g. new compliance event or policy update). Since spec-sync is already watching the managed cluster's replicated policies on the hub, it can do the work of detecting the status mismatch on the hub and managed cluster, and trigger a status-sync reconcile to have the status-sync controller fix it. Relates: https://issues.redhat.com/browse/ACM-12447 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
|
/unhold |
dhaiducek
approved these changes
Jul 2, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit de1345a
into
open-cluster-management-io:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since status-sync watches the managed cluster's replicated policies on the managed cluster (not the hub), it has a blind spot for when the hub's status doesn't match and nothing triggers a status-sync reconcile (e.g. new compliance event or policy update). Since spec-sync is already watching the managed cluster's replicated policies on the hub, it can do the work of detecting the status mismatch on the hub and managed cluster, and trigger a status-sync reconcile to have the status-sync controller fix it.
Relates:
https://issues.redhat.com/browse/ACM-12447