-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger status-sync reconciles when spec-sync sees mismatching status #148
Trigger status-sync reconciles when spec-sync sees mismatching status #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold for minor E2E update and other reviews
Seems right to me! Thanks for the update!
Since status-sync watches the managed cluster's replicated policies on the managed cluster (not the hub), it has a blind spot for when the hub's status doesn't match and nothing triggers a status-sync reconcile (e.g. new compliance event or policy update). Since spec-sync is already watching the managed cluster's replicated policies on the hub, it can do the work of detecting the status mismatch on the hub and managed cluster, and trigger a status-sync reconcile to have the status-sync controller fix it. Relates: https://issues.redhat.com/browse/ACM-12447 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
de1345a
into
open-cluster-management-io:main
Since status-sync watches the managed cluster's replicated policies on the managed cluster (not the hub), it has a blind spot for when the hub's status doesn't match and nothing triggers a status-sync reconcile (e.g. new compliance event or policy update). Since spec-sync is already watching the managed cluster's replicated policies on the hub, it can do the work of detecting the status mismatch on the hub and managed cluster, and trigger a status-sync reconcile to have the status-sync controller fix it.
Relates:
https://issues.redhat.com/browse/ACM-12447