Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Remove the enableAddOnDeploymentConfig value #114

Merged

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Jun 19, 2024

Summary

Remove the enableAddOnDeploymentConfig value to fix helm template error when enableAddOnDeploymentConfig is false, but hubDeployMode is AddOnTemplate. the addonDeploymentConfig should always be enabled.

╰─# helm template charts/managed-serviceaccount
Error: YAML parse error on managed-serviceaccount/templates/clustermanagementaddon.yaml: error converting YAML to JSON: yaml: line 10: did not find expected key

Use --debug flag to render out invalid YAML

Related issue(s)

Fixes #

@zhujian7 zhujian7 changed the title Fix helm template error 🐛 Fix helm template error Jun 19, 2024
@zhujian7
Copy link
Member Author

/cc @qiujian16

@qiujian16
Copy link
Member

actually can we remove enableAddOnDeploymentConfig? we can alway enable it

Signed-off-by: zhujian <jiazhu@redhat.com>
Signed-off-by: zhujian <jiazhu@redhat.com>
@zhujian7 zhujian7 changed the title 🐛 Fix helm template error 🐛 Remove the enableAddOnDeploymentConfig value Jun 19, 2024
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 43435c4 into open-cluster-management-io:main Jun 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants