Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh token until remaining lifetime < 20% validity #49

Merged
merged 1 commit into from
Sep 26, 2022
Merged

refresh token until remaining lifetime < 20% validity #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/addon/agent/controller/token.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,10 @@ func (r *TokenReconciler) isSoonExpiring(managed *authv1alpha1.ManagedServiceAcc
}

// check if the token should be refreshed
// the token will not be rotated unless its remaining lifetime is less
// than 20% of its rotation validity
now := metav1.Now()
refreshThreshold := managed.Spec.Rotation.Validity.Duration / 5 * 4
refreshThreshold := managed.Spec.Rotation.Validity.Duration / 5 * 1
lifetime := managed.Status.ExpirationTimestamp.Sub(now.Time)
if lifetime < refreshThreshold {
return true, nil
Expand Down