Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove securityContext log errors in OCP 4.11+ #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eemurphy
Copy link

@eemurphy eemurphy commented Jun 1, 2023

ACM Installer team is cleaning up our logs and ran into KupeAPIWarnings that the seccompProfile needs to be set to RuntimeDefault for our operands. Please add this conditional in the deployment yaml to fix the error.

issue: https://issues.redhat.com/browse/ACM-3072

Signed-off-by: Erin Murphy erinmurp@redhat.com

@qiujian16
Copy link
Member

hi @eemurphy the commit needs signoff, thanks!

Signed-off-by: Erin Murphy <erinmurp@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eemurphy
Once this PR has been reviewed and has the lgtm label, please assign yue9944882 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@4439d50). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage        ?   80.52%           
=======================================
  Files           ?        5           
  Lines           ?      416           
  Branches        ?        0           
=======================================
  Hits            ?      335           
  Misses          ?       64           
  Partials        ?       17           
Flag Coverage Δ
unit 80.52% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhujian7
Copy link
Member

Hi @eemurphy do we still need this? there seems no hubconfig.ocpVersion value defined in our community version managed-serviceaccount.

zhujian7 pushed a commit to zhujian7/managed-serviceaccount that referenced this pull request Apr 18, 2024
Co-authored-by: red-hat-konflux <123456+red-hat-konflux[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants