Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump k8s to 0.27.4 and golang to 1.20 #73

Merged

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Aug 10, 2023

This PR resolved the conflicts of #66, and fixed the unit tests based on kubernetes-sigs/controller-runtime#2259
@clyang82, please help review

clyang82 and others added 2 commits August 10, 2023 04:04
Signed-off-by: clyang82 <chuyang@redhat.com>
Signed-off-by: zhujian <jiazhu@redhat.com>
@zhujian7
Copy link
Member Author

cc @elgnay @qiujian16

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: +0.78% 🎉

Comparison is base (632006c) 80.52% compared to head (70219f4) 81.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   80.52%   81.31%   +0.78%     
==========================================
  Files           5        5              
  Lines         416      412       -4     
==========================================
  Hits          335      335              
+ Misses         64       60       -4     
  Partials       17       17              
Flag Coverage Δ
unit 81.31% <57.14%> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/addon/agent/controller/token.go 71.42% <0.00%> (+0.72%) ⬆️
.../commoncontroller/ephemeral_identity_controller.go 71.73% <0.00%> (+2.98%) ⬆️
pkg/controllers/event/secret.go 100.00% <100.00%> (ø)
pkg/controllers/event/serviceaccount.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clyang82
Copy link
Contributor

/lgtm

Signed-off-by: zhujian <jiazhu@redhat.com>
@@ -1,5 +1,8 @@
coverage:
status:
patch:
Copy link
Member Author

@zhujian7 zhujian7 Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open the informational mode for new code checking, so reviewers can know which new lines are not covered, and it also will not block the PR merge. https://docs.codecov.com/docs/commit-status#informational

cc @qiujian16 @xuezhaojun @clyang82

@xuezhaojun
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit 60c41e7 into open-cluster-management-io:main Aug 14, 2023
9 checks passed
zhujian7 pushed a commit to zhujian7/managed-serviceaccount that referenced this pull request May 6, 2024
Co-authored-by: red-hat-konflux <123456+red-hat-konflux[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants