Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky unit test for the placement scheduling #233

Closed
zhujian7 opened this issue Jul 25, 2023 · 3 comments · Fixed by #235
Closed

Flaky unit test for the placement scheduling #233

zhujian7 opened this issue Jul 25, 2023 · 3 comments · Fixed by #235
Assignees
Labels
bug Something isn't working

Comments

@zhujian7
Copy link
Member

zhujian7 commented Jul 25, 2023

--- FAIL: TestBind (0.02s)
    --- FAIL: TestBind/create_placementdecision_with_only_cluster_per_decision_group (0.00s)
        scheduling_controller_test.go:1429: expected clusters selected: cluster1, but got [{cluster3 }]
        scheduling_controller_test.go:1429: expected clusters selected: cluster2, but got [{cluster1 }]
        scheduling_controller_test.go:1429: expected clusters selected: cluster3, but got [{cluster2 }]
FAIL
        open-cluster-management.io/ocm/pkg/placement/controllers/scheduling     coverage: 75.5% of statements
FAIL    open-cluster-management.io/ocm/pkg/placement/controllers/scheduling     0.298s

see https://github.com/open-cluster-management-io/ocm/actions/runs/5654038071/job/15316306014?pr=231

cc @haoqing0110

@qiujian16
Copy link
Member

I see this error sometimes also

/kind bug
/assign @haoqing0110

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

@qiujian16: The label(s) kind/bug cannot be applied, because the repository doesn't have them.

In response to this:

I see this error sometimes also

/kind bug
/assign @haoqing0110

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haoqing0110
Copy link
Member

Will fix in #235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants