Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster auto approve could fail occasionally #386

Closed
qiujian16 opened this issue Mar 29, 2024 · 1 comment · Fixed by #388
Closed

cluster auto approve could fail occasionally #386

qiujian16 opened this issue Mar 29, 2024 · 1 comment · Fixed by #388
Assignees
Labels
bug Something isn't working

Comments

@qiujian16
Copy link
Member

Describe the bug
When enable the AutoApprove feature gate, sometimes the cluster will not be get accepted by the hub due to timing issue.

To Reproduce
enable the AutoApprove feature gate with clusteradmin init and run clusteradm join. It happens occasionally.

Expected behavior
The cluster should be always approved

Environment ie: OCM version, Kubernetes version and provider:
latest

Additional context
Add any other context about the problem here.

@skeeey
Copy link
Member

skeeey commented Mar 29, 2024

/assign @skeeey

nirs added a commit to nirs/ramen that referenced this issue Apr 1, 2024
I pushed images with fix[1] for issue[2] to my private repo.

[1] open-cluster-management-io/ocm#388
[2] open-cluster-management-io/ocm#386

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this issue Apr 1, 2024
I pushed images with fix[1] for issue[2] to my private repo.

[1] open-cluster-management-io/ocm#388
[2] open-cluster-management-io/ocm#386

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this issue Apr 1, 2024
I pushed images with fix[1] for issue[2] to my private repo.

[1] open-cluster-management-io/ocm#388
[2] open-cluster-management-io/ocm#386

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this issue Apr 1, 2024
I pushed images with fix[1] for issue[2] to my private repo.

[1] open-cluster-management-io/ocm#388
[2] open-cluster-management-io/ocm#386

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this issue Apr 2, 2024
I pushed images with fix[1] for issue[2] to my private repo.

[1] open-cluster-management-io/ocm#388
[2] open-cluster-management-io/ocm#386

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this issue Apr 2, 2024
I pushed images with fix[1] for issue[2] to my private repo.

[1] open-cluster-management-io/ocm#388
[2] open-cluster-management-io/ocm#386

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this issue Apr 2, 2024
I pushed images with fix[1] for issue[2] to my private repo.

[1] open-cluster-management-io/ocm#388
[2] open-cluster-management-io/ocm#386

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this issue Apr 3, 2024
I pushed images with fix[1] for issue[2] to my private repo.

[1] open-cluster-management-io/ocm#388
[2] open-cluster-management-io/ocm#386

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this issue Apr 4, 2024
I pushed images with fix[1] for issue[2] to my private repo.

[1] open-cluster-management-io/ocm#388
[2] open-cluster-management-io/ocm#386

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this issue Apr 6, 2024
I pushed images with fix[1] for issue[2] to my private repo.

[1] open-cluster-management-io/ocm#388
[2] open-cluster-management-io/ocm#386

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this issue Apr 7, 2024
I pushed images with fix[1] for issue[2] to my private repo.

[1] open-cluster-management-io/ocm#388
[2] open-cluster-management-io/ocm#386

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this issue Apr 8, 2024
I pushed images with fix[1] for issue[2] to my private repo.

[1] open-cluster-management-io/ocm#388
[2] open-cluster-management-io/ocm#386

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this issue Apr 8, 2024
I pushed images with fix[1] for issue[2] to my private repo.

[1] open-cluster-management-io/ocm#388
[2] open-cluster-management-io/ocm#386

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this issue Apr 9, 2024
I pushed images with fix[1] for issue[2] to my private repo.

[1] open-cluster-management-io/ocm#388
[2] open-cluster-management-io/ocm#386

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants