Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the community have a standard way of calculating code coverage? #85

Closed
gparvin opened this issue Nov 2, 2022 · 5 comments
Closed

Comments

@gparvin
Copy link
Member

gparvin commented Nov 2, 2022

We would like to know if this community has a standard way of checking code coverage. We are using a script now at least in this repository: https://github.com/open-cluster-management-io/governance-policy-propagator/blob/main/build/common/scripts/coverage_calc.sh

Are there other code quality checks that are recommended for OCM too?

@qiujian16
Copy link
Member

@xuezhaojun is investigating codecov, and it is used in cluster-proxy already. We would consider using codecov across the community.

@xuezhaojun
Copy link
Member

xuezhaojun commented Mar 22, 2023

@gparvin Hi, Gus, it‘s easy to setup a coverage check in github actions, there is a PR you can refer to: https://github.com/open-cluster-management-io/cluster-proxy/pull/150/files; And you also need to enable the repo in Codecov(login with github).

But we don't set a restrictive rule at this point in time. Repo owners can decide by themselves what target and threshold are reasonable for their projects.

@xuezhaojun
Copy link
Member

xuezhaojun commented Jul 17, 2023

/close

1 similar comment
@qiujian16
Copy link
Member

/close

@openshift-ci openshift-ci bot closed this as completed Jul 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

@qiujian16: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zhujian7 pushed a commit to zhujian7/ocm that referenced this issue Jul 25, 2024
…agement-io#85)

Co-authored-by: red-hat-konflux <konflux@no-reply.konflux-ci.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants