Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move placement e2e out of staging #158

Conversation

qiujian16
Copy link
Member

@qiujian16 qiujian16 commented Jun 1, 2023

this replace the previous placement e2e in registration-operator by e2e in placement, since the latter has covered the former

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@openshift-ci openshift-ci bot requested review from deads2k and suigh June 1, 2023 10:34
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 1, 2023
@xuezhaojun
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 1, 2023
@openshift-merge-robot openshift-merge-robot merged commit 384a3f4 into open-cluster-management-io:main Jun 1, 2023
clyang82 pushed a commit to clyang82/ocm that referenced this pull request Jun 2, 2023
…er-management-io#158)

* validate manifest work executor permission on hub cluster

Signed-off-by: zhujian <jiazhu@redhat.com>

* do not validate the executor when it is not changed

Signed-off-by: zhujian <jiazhu@redhat.com>

Signed-off-by: zhujian <jiazhu@redhat.com>
zhujian7 added a commit to zhujian7/ocm that referenced this pull request Dec 2, 2024
Signed-off-by: zhujian <jiazhu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants