stabilize placement integration test #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqing0110
pushed a commit
to haoqing0110/OCM
that referenced
this pull request
Jun 5, 2023
* cache the executor validation results Signed-off-by: zhujian <jiazhu@redhat.com> * move executor cache controller to auth package Signed-off-by: zhujian <jiazhu@redhat.com> * add a binding resource executor mapper to process delete event Signed-off-by: zhujian <jiazhu@redhat.com> * initialize caches before starting the cache controller Signed-off-by: zhujian <jiazhu@redhat.com> * read enable executor caches from flag Signed-off-by: zhujian <jiazhu@redhat.com> * add unit tests for cache store Signed-off-by: zhujian <jiazhu@redhat.com> * add unit tests for cache validator Signed-off-by: zhujian <jiazhu@redhat.com> * add unit tests for cache controller Signed-off-by: zhujian <jiazhu@redhat.com> * read enable executor caches from feature gate Signed-off-by: zhujian <jiazhu@redhat.com> * add integration tests for cache controller Signed-off-by: zhujian <jiazhu@redhat.com> * add a description doc for the cache package Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com>
|
/assign @qiujian16 |
qiujian16
reviewed
Jun 5, 2023
| placement, err = clusterClient.ClusterV1beta1().Placements(namespace).Update(context.Background(), placement, metav1.UpdateOptions{}) | ||
| gomega.Expect(err).ToNot(gomega.HaveOccurred()) | ||
| placement.Spec.Tolerations = tolerations | ||
| gomega.Eventually(func() error { |
There was a problem hiding this comment.
I think you need to put get in the eventually also
haoqing0110
force-pushed
the
br_placement
branch
3 times, most recently
from
cc7f37d
to
10749fc
Compare
qiujian16
reviewed
Jun 5, 2023
There was a problem hiding this comment.
@haoqing0110 I am fine to merge this to fix the flaky issue, but we should consider using patch. the assertUpdatingPlacement cannot update partial of the spec which may cause some complexity in the future.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: haoqing0110 <qhao@redhat.com>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #162