Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 docs Add: Added argocd pull docs #168

Conversation

o-farag
Copy link
Contributor

@o-farag o-farag commented Jun 6, 2023

Added separate folder for argocd pull model docs

@openshift-ci openshift-ci bot requested review from jnpacker and qiujian16 June 6, 2023 19:31
@o-farag
Copy link
Contributor Author

o-farag commented Jun 6, 2023

@mikeshng let me know if there is more I can add to troubleshooting or the general overview

Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the excellent entry @o-farag !

Just some minor nits and we are good to go.

solutions/deploy-argocd-apps-pull/argocd-pull-model.md Outdated Show resolved Hide resolved
solutions/deploy-argocd-apps-pull/getting-started.md Outdated Show resolved Hide resolved
solutions/deploy-argocd-apps-pull/getting-started.md Outdated Show resolved Hide resolved
solutions/deploy-argocd-apps-pull/getting-started.md Outdated Show resolved Hide resolved
solutions/deploy-argocd-apps-pull/getting-started.md Outdated Show resolved Hide resolved
solutions/deploy-argocd-apps-pull/troubleshooting.md Outdated Show resolved Hide resolved
solutions/deploy-argocd-apps-pull/troubleshooting.md Outdated Show resolved Hide resolved
solutions/deploy-argocd-apps-pull/troubleshooting.md Outdated Show resolved Hide resolved
solutions/deploy-argocd-apps-pull/troubleshooting.md Outdated Show resolved Hide resolved
solutions/deploy-argocd-apps-pull/troubleshooting.md Outdated Show resolved Hide resolved
@qiujian16
Copy link
Member

@o-farag would you also rebase the PR, we are trying to skip the test part for doc only PR #169

o-farag added 2 commits June 7, 2023 15:46
Signed-off-by: Omar Farag <ofarag@redhat.com>
Signed-off-by: Omar Farag <ofarag@redhat.com>
@o-farag o-farag force-pushed the deploy-argocd-apps-pull branch from 436bc24 to 58678fa Compare June 7, 2023 19:48
@o-farag o-farag changed the title Added argocd pull docs Add: Added argocd pull docs Jun 7, 2023
@o-farag o-farag requested a review from mikeshng June 7, 2023 19:56
@mikeshng mikeshng changed the title Add: Added argocd pull docs 📖 📖 docs Add: Added argocd pull docs Jun 7, 2023
@mikeshng mikeshng changed the title 📖 📖 docs Add: Added argocd pull docs 📖 docs Add: Added argocd pull docs Jun 7, 2023
@mikeshng
Copy link
Member

mikeshng commented Jun 7, 2023

/approve

/lgtm

Excellent work @o-farag !!!!!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, o-farag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit 483612a into open-cluster-management-io:main Jun 7, 2023
zhujian7 added a commit to zhujian7/ocm that referenced this pull request Jun 8, 2023
Signed-off-by: zhujian <jiazhu@redhat.com>

Signed-off-by: zhujian <jiazhu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants