Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR verify action #171

Merged

Conversation

qiujian16
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot requested review from jnpacker and mikeshng June 7, 2023 13:10
@openshift-ci openshift-ci bot added the approved label Jun 7, 2023
Signed-off-by: Jian Qiu <jqiu@redhat.com>
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@83152d4). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage        ?   58.42%           
=======================================
  Files           ?      107           
  Lines           ?    11847           
  Branches        ?        0           
=======================================
  Hits            ?     6922           
  Misses          ?     4254           
  Partials        ?      671           
Flag Coverage Δ
unit 58.42% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3105fbf into open-cluster-management-io:main Jun 7, 2023
@qiujian16 qiujian16 deleted the pr-verify branch June 8, 2023 02:19
zhujian7 pushed a commit to zhujian7/ocm that referenced this pull request Jun 8, 2023
…nagement-io#171)

* Add inital skeleton for placeManifestWork controller

Signed-off-by: melserngawy <melserng@redhat.com>

* Update vendor

Signed-off-by: melserngawy <melserng@redhat.com>

* fix pkgs

Signed-off-by: melserngawy <melserng@redhat.com>

Signed-off-by: melserngawy <melserng@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants