Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Configure the golangci lint #180

Merged

Conversation

zhujian7
Copy link
Member

Summary

Add a .golangci.yaml file to configure the golang cilint.

Related issue(s)

Fixes #

Signed-off-by: zhujian <jiazhu@redhat.com>
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 82.60% and project coverage change: +0.01 🎉

Comparison is base (7332a58) 58.36% compared to head (ff3b7da) 58.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   58.36%   58.37%   +0.01%     
==========================================
  Files         109      109              
  Lines       11713    11756      +43     
==========================================
+ Hits         6836     6863      +27     
- Misses       4212     4228      +16     
  Partials      665      665              
Flag Coverage Δ
unit 58.37% <82.60%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/operator/certrotation/cabundle.go 46.15% <0.00%> (-0.73%) ⬇️
pkg/operator/operators/crdmanager/manager.go 60.33% <ø> (ø)
...et/controllers/addonsecretcontroller/controller.go 47.05% <0.00%> (+1.77%) ⬆️
...nt/controllers/scheduling/scheduling_controller.go 57.82% <ø> (ø)
pkg/registration/clientcert/certficate_beta.go 33.33% <0.00%> (ø)
pkg/registration/clientcert/certificate.go 42.61% <0.00%> (ø)
pkg/registration/hub/clusterrole/controller.go 53.48% <ø> (ø)
...kg/registration/spoke/registration/registration.go 9.32% <0.00%> (ø)
pkg/registration/spoke/spokeagent.go 30.90% <0.00%> (-1.18%) ⬇️
...registration/webhook/v1/managedcluster_mutating.go 77.92% <ø> (ø)
... and 40 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhujian7 zhujian7 changed the title WIP:seedling: Configure the golangci lint 🌱 Configure the golangci lint Jun 13, 2023
@zhujian7 zhujian7 force-pushed the golint branch 3 times, most recently from cd34fef to f9213ac Compare June 13, 2023 06:21
Signed-off-by: zhujian <jiazhu@redhat.com>
@zhujian7
Copy link
Member Author

/assign @qiujian16

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d3d6482 into open-cluster-management-io:main Jun 13, 2023
ycyaoxdu pushed a commit to ycyaoxdu/ocm that referenced this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants