Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛merge the cluster capacity #184

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

skeeey
Copy link
Member

@skeeey skeeey commented Jun 14, 2023

Summary

rollback the merging the cluster capacity code

Related issue(s)

if the other component update the cluster capacity, the registration agent will recover the changes

@openshift-ci openshift-ci bot requested review from elgnay and ldpliu June 14, 2023 06:54
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (c364d34) 58.35% compared to head (7f1f91e) 58.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   58.35%   58.39%   +0.03%     
==========================================
  Files         109      109              
  Lines       11756    11760       +4     
==========================================
+ Hits         6860     6867       +7     
+ Misses       4230     4228       -2     
+ Partials      666      665       -1     
Flag Coverage Δ
unit 58.39% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tration/spoke/managedcluster/resource_reconcile.go 78.04% <100.00%> (+1.12%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skeeey
Copy link
Member Author

skeeey commented Jun 14, 2023

/assign @qiujian16

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, skeeey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Wei Liu <liuweixa@redhat.com>
@qiujian16
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit ecfb6c0 into open-cluster-management-io:main Jun 14, 2023
mikeshng pushed a commit to mikeshng/ocm that referenced this pull request Jun 20, 2023
…#184)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.1.0 to 0.7.0.
- [Release notes](https://github.com/golang/net/releases)
- [Commits](golang/net@v0.1.0...v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@skeeey skeeey deleted the claim branch January 19, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants