Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 change build image to fix GLIBC not found issue #187

Conversation

zhiweiyin318
Copy link
Member

Summary

Related issue(s)

the latest golang:1.20 image upgade ldd to 2.32, the built image cannot run with error

/placement: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by /placement)
/placement: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by /placement)

change the image to 1.20-bullseye which ldd version is 2.31.
Fixes #

Signed-off-by: Zhiwei Yin <zyin@redhat.com>
@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 June 15, 2023 15:04
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhiweiyin318
Once this PR has been reviewed and has the lgtm label, please assign qiujian16 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (023cdfd) 58.37% compared to head (f07acfe) 58.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   58.37%   58.39%   +0.01%     
==========================================
  Files         109      109              
  Lines       11756    11760       +4     
==========================================
+ Hits         6863     6867       +4     
  Misses       4228     4228              
  Partials      665      665              
Flag Coverage Δ
unit 58.39% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhiweiyin318 zhiweiyin318 deleted the change-buildimage branch June 16, 2023 05:43
mikeshng pushed a commit to mikeshng/ocm that referenced this pull request Jun 20, 2023
…gement-io#187)

* Rename placeManifestWork to manifestWorkReplicaSet

Signed-off-by: melserngawy <melserng@redhat.com>

* Rename apis and variables

Signed-off-by: melserngawy <melserng@redhat.com>

---------

Signed-off-by: melserngawy <melserng@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant