Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 waiting the approved csr if it is not found in integration test #188

Merged

Conversation

skeeey
Copy link
Member

@skeeey skeeey commented Jun 16, 2023

Summary

Related issue(s)

Fixes #

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (023cdfd) 58.37% compared to head (a7321d0) 58.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   58.37%   58.36%   -0.02%     
==========================================
  Files         109      109              
  Lines       11756    11760       +4     
==========================================
+ Hits         6863     6864       +1     
- Misses       4228     4230       +2     
- Partials      665      666       +1     
Flag Coverage Δ
unit 58.36% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tration/spoke/managedcluster/resource_reconcile.go 78.04% <100.00%> (+1.12%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skeeey skeeey force-pushed the autoapprove-test branch 3 times, most recently from af4cddc to d88097b Compare June 16, 2023 04:09
@openshift-ci openshift-ci bot removed the approved label Jun 16, 2023
@skeeey
Copy link
Member Author

skeeey commented Jun 16, 2023

/hold

I will run the test multiple times

Signed-off-by: Wei Liu <liuweixa@redhat.com>
@skeeey
Copy link
Member Author

skeeey commented Jun 16, 2023

/unhold

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, skeeey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 946e22e into open-cluster-management-io:main Jun 16, 2023
10 checks passed
mikeshng pushed a commit to mikeshng/ocm that referenced this pull request Jun 20, 2023
…1.0 (open-cluster-management-io#188)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.0.0-20220214200702-86341886e292 to 0.1.0.
- [Release notes](https://github.com/golang/crypto/releases)
- [Commits](https://github.com/golang/crypto/commits/v0.1.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@skeeey skeeey deleted the autoapprove-test branch January 19, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants