Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 doc fix: ArgoCD pull solution doc should render on browser folder entry #192

Conversation

mikeshng
Copy link
Member

Summary

The argocd pull solution is not displaying nicely when browsing to https://github.com/open-cluster-management-io/ocm/tree/main/solutions/deploy-argocd-apps-pull

It should behave similar to https://github.com/open-cluster-management-io/ocm/tree/main/solutions/deploy-argocd-apps where contents are displayed upon browser entry.

@openshift-ci openshift-ci bot requested review from deads2k and jnpacker June 20, 2023 16:36
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikeshng
Copy link
Member Author

/assign @qiujian16

@qiujian16
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 21, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6c4dbb9 into open-cluster-management-io:main Jun 21, 2023
haoqing0110 pushed a commit to haoqing0110/OCM that referenced this pull request Jun 26, 2023
)

Signed-off-by: melserngawy <melserng@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants