Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Trigger clusteradm e2e after post images. #209

Conversation

xuezhaojun
Copy link
Member

@openshift-ci openshift-ci bot requested review from deads2k and mikeshng July 3, 2023 14:59
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9cae24c) 59.69% compared to head (7bdfbde) 59.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   59.69%   59.69%           
=======================================
  Files         128      128           
  Lines       13247    13247           
=======================================
  Hits         7908     7908           
  Misses       4598     4598           
  Partials      741      741           
Flag Coverage Δ
unit 59.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

with:
token: ${{ secrets.OCM_BOT_PAT }}
repository: open-cluster-management-io/clusteradm
event-type: ocm_changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also send the commit sha, so clusteradm will know which commit triggers?

Copy link
Member Author

@xuezhaojun xuezhaojun Jul 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, the sha and ref added in the next line.

Signed-off-by: xuezhaojun <zxue@redhat.com>
@xuezhaojun xuezhaojun force-pushed the send-registry-dispatch-to-clusteradm branch from c1a2769 to 7bdfbde Compare July 4, 2023 01:25
@xuezhaojun xuezhaojun closed this Jul 4, 2023
@xuezhaojun xuezhaojun reopened this Jul 4, 2023
steps:
- uses: peter-evans/repository-dispatch@v2
with:
token: ${{ secrets.OCM_BOT_PAT }}
Copy link
Member Author

@xuezhaojun xuezhaojun Jul 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @mikeshng does OCM_BOT_PAT have the write permission on Contents? The permission is needed to send a repository-dispatch event.
image

@xuezhaojun
Copy link
Member Author

/assign @qiujian16

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit eb9b7fa into open-cluster-management-io:main Jul 4, 2023
@xuezhaojun xuezhaojun deleted the send-registry-dispatch-to-clusteradm branch July 4, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants