🌱 Reduce e2e process time #210
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qiujian16
force-pushed
the
reduce-e2e-time
branch
from
d9bf92d to
398ca41
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
=======================================
Coverage 59.91% 59.91%
=======================================
Files 128 128
Lines 13241 13241
=======================================
Hits 7933 7933
+ Misses 4569 4568 -1
- Partials 739 740 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
qiujian16
force-pushed
the
reduce-e2e-time
branch
7 times, most recently
from
0a2b2eb to
fc069c7
Compare
qiujian16
force-pushed
the
reduce-e2e-time
branch
from
fc069c7 to
15e6c68
Compare
for work and addon e2e, we do not need to restart klusterlet for each case Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
reduce-e2e-time
branch
from
15e6c68 to
9c4fd5f
Compare
| @@ -44,9 +44,9 @@ var ( | |||
| } | |||
| ) | |||
|
|
|||
| var _ = ginkgo.Describe("Enable addon management feature gate", ginkgo.Label("addon-manager"), func() { | |||
| var _ = ginkgo.Describe("Enable addon management feature gate", ginkgo.Ordered, ginkgo.Label("addon-manager"), func() { | |||
There was a problem hiding this comment.
why do we need the ginkgo.Ordered for this test?
There was a problem hiding this comment.
since we use the same addon name in each test case, so the two cannot run concurrently. It also help us to add a BeforeAll and AfterAll to enable/disable the feature gates, so we do not need to enable/disable for each case.
|
/lgtm |
Summary
for work and addon e2e, we do not need to
restart klusterlet for each case
Related issue(s)
Fixes #