🐛 refactor rbacfinalizercontroller to fix cluster ns is terminating after delete clustermanager #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiweiyin318
force-pushed
the
refactor-rbacfinalizer
branch
2 times, most recently
from
6fa715e to
99a0675
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
+ Coverage 59.62% 59.71% +0.08%
==========================================
Files 128 128
Lines 13262 13243 -19
==========================================
Hits 7908 7908
+ Misses 4613 4595 -18
+ Partials 741 740 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
zhiweiyin318
force-pushed
the
refactor-rbacfinalizer
branch
from
99a0675 to
7eeca47
Compare
zhiweiyin318
changed the title
zhiweiyin318
force-pushed
the
refactor-rbacfinalizer
branch
2 times, most recently
from
0df9ef0 to
72c576e
Compare
…er delete clustermanager Signed-off-by: Zhiwei Yin <zyin@redhat.com>
zhiweiyin318
force-pushed
the
refactor-rbacfinalizer
branch
from
72c576e to
499e66a
Compare
|
/assign @qiujian16 |
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, skeeey, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
when delete clustermanager cr, the registration-controller is deleted so fast to not remove the finalizer on work rolebinding in the cluster namespace. this PR is to refactor rbacfinalizercontroler to watch mcl and ns, remove the finalizer if there is no manifestworks when mcl or ns is deleting.
Fixes #