Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 use DeploymentAvailability to check addon health #212

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Jul 5, 2023

Summary

so if addon developers use the addon template to develop an addon, they are not required to update the lease for the addon.

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from ldpliu and skeeey July 5, 2023 04:13
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 14.28% and project coverage change: +0.17 🎉

Comparison is base (d93268b) 59.73% compared to head (392a4ee) 59.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   59.73%   59.91%   +0.17%     
==========================================
  Files         128      128              
  Lines       13254    13241      -13     
==========================================
+ Hits         7917     7933      +16     
+ Misses       4597     4568      -29     
  Partials      740      740              
Flag Coverage Δ
unit 59.91% <14.28%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/addon/controllers/addontemplate/controller.go 66.66% <0.00%> (+21.28%) ⬆️
pkg/addon/templateagent/template_agent.go 55.88% <16.66%> (-1.88%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhujian7
Copy link
Member Author

zhujian7 commented Jul 5, 2023

@qiujian16 @zhiweiyin318

@zhiweiyin318
Copy link
Member

/lgtm

@qiujian16
Copy link
Member

Could we add some unit test to try not reduce coverage?

@zhujian7 zhujian7 force-pushed the addon-health-probe branch from 1533446 to fb40886 Compare July 5, 2023 09:35
@openshift-ci openshift-ci bot removed the lgtm label Jul 5, 2023
Signed-off-by: zhujian <jiazhu@redhat.com>
@zhujian7 zhujian7 force-pushed the addon-health-probe branch from fb40886 to 392a4ee Compare July 5, 2023 10:08
@zhujian7
Copy link
Member Author

zhujian7 commented Jul 5, 2023

@qiujian16 PTAL

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit 21ee8d4 into open-cluster-management-io:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants