-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 use DeploymentAvailability to check addon health #212
🌱 use DeploymentAvailability to check addon health #212
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
==========================================
+ Coverage 59.73% 59.91% +0.17%
==========================================
Files 128 128
Lines 13254 13241 -13
==========================================
+ Hits 7917 7933 +16
+ Misses 4597 4568 -29
Partials 740 740
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
/lgtm |
Could we add some unit test to try not reduce coverage? |
1533446
to
fb40886
Compare
Signed-off-by: zhujian <jiazhu@redhat.com>
fb40886
to
392a4ee
Compare
@qiujian16 PTAL |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
so if addon developers use the addon template to develop an addon, they are not required to update the lease for the addon.
Related issue(s)
Fixes #