Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 adding contextual logging in registration component #220

Conversation

nitishchauhan0022
Copy link
Contributor

@zhujian7
Copy link
Member

/ok-to-test

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 73.56% and project coverage change: +0.08% 🎉

Comparison is base (e22faa4) 60.29% compared to head (71d1489) 60.37%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   60.29%   60.37%   +0.08%     
==========================================
  Files         131      132       +1     
  Lines       13543    13616      +73     
==========================================
+ Hits         8166     8221      +55     
- Misses       4625     4641      +16     
- Partials      752      754       +2     
Flag Coverage Δ
unit 60.37% <73.56%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/common/options/agent.go 66.66% <ø> (ø)
pkg/common/options/options.go 100.00% <ø> (ø)
...llers/crdstatuccontroller/crd_status_controller.go 37.31% <ø> (ø)
...sterletcontroller/klusterlet_cleanup_controller.go 55.10% <ø> (ø)
...lers/klusterletcontroller/klusterlet_controller.go 69.54% <0.00%> (-0.50%) ⬇️
...llers/ssarcontroller/klusterlet_ssar_controller.go 76.98% <ø> (-0.07%) ⬇️
...nt/controllers/scheduling/cluster_event_handler.go 59.25% <ø> (ø)
pkg/placement/debugger/debugger.go 52.63% <ø> (ø)
...stration/spoke/managedcluster/status_controller.go 53.06% <ø> (ø)
...setcontroller/manifestworkreplicaset_controller.go 48.19% <ø> (ø)
... and 43 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhujian7
Copy link
Member

zhujian7 commented Jul 14, 2023

@nitishchauhan0022 Thanks for your PR, there are two checks that failed

  1. PR Verifier, please add the emoji to the PR title based on the PR template, like :seedling:
  2. verify, please execute make verify locally. BTW, make fmt-imports may help avoid some unnecessary trouble

Thank you again.

@qiujian16
Copy link
Member

@nitishchauhan0022 thanks please also update the PR title follow the PR template

@qiujian16
Copy link
Member

and instead of one PR to fix all. I think you could also consider multiple PRs, each for one component. This could reduce the risk of conflict.

@nitishchauhan0022 nitishchauhan0022 changed the title adding contextual logging 🌱 adding contextual logging in registration component Jul 14, 2023
@nitishchauhan0022
Copy link
Contributor Author

hey @qiujian16 @zhujian7 updated the pr, please review

@qiujian16
Copy link
Member

hrm I do not know why e2e fails, would you rebase the PR and trigger the test again?

Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
@@ -15,9 +15,9 @@ ConvertTo is expected to modify its argument to contain the converted object.
Most of the conversion is straightforward copying, except for converting our changed field.
*/
// ConvertTo converts this ManagedClusterSet to the Hub(v1beta1) version.
func (src *ManagedClusterSet) ConvertTo(dstRaw conversion.Hub) error {
func (src *ManagedClusterSet) ConvertTo(logger klog.Logger, dstRaw conversion.Hub) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cannot change ConvertTo and ConvertFrom func's signature. It will break the webhook

@qiujian16
Copy link
Member

@nitishchauhan0022 would you revert the change in the webhook part. I think it changes the func signature and makes webhook unable to start. I think we can skip webhook in this PR. Thanks!

Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
@qiujian16
Copy link
Member

/approve
/lgtm

Thanks for your contribution!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nitishchauhan0022, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6e0937e into open-cluster-management-io:main Aug 15, 2023
12 checks passed
@nitishchauhan0022
Copy link
Contributor Author

@qiujian16 Thanks for the merge, i will open the prs for the remaining components this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use contextual logging in ocm
4 participants