-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 adding contextual logging in registration component #220
🌱 adding contextual logging in registration component #220
Conversation
/ok-to-test |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
==========================================
+ Coverage 60.29% 60.37% +0.08%
==========================================
Files 131 132 +1
Lines 13543 13616 +73
==========================================
+ Hits 8166 8221 +55
- Misses 4625 4641 +16
- Partials 752 754 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@nitishchauhan0022 Thanks for your PR, there are two checks that failed
Thank you again. |
@nitishchauhan0022 thanks please also update the PR title follow the PR template |
and instead of one PR to fix all. I think you could also consider multiple PRs, each for one component. This could reduce the risk of conflict. |
c181f00
to
33928ec
Compare
33928ec
to
eb8a04f
Compare
hey @qiujian16 @zhujian7 updated the pr, please review |
hrm I do not know why e2e fails, would you rebase the PR and trigger the test again? |
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
eb8a04f
to
ef6adeb
Compare
@@ -15,9 +15,9 @@ ConvertTo is expected to modify its argument to contain the converted object. | |||
Most of the conversion is straightforward copying, except for converting our changed field. | |||
*/ | |||
// ConvertTo converts this ManagedClusterSet to the Hub(v1beta1) version. | |||
func (src *ManagedClusterSet) ConvertTo(dstRaw conversion.Hub) error { | |||
func (src *ManagedClusterSet) ConvertTo(logger klog.Logger, dstRaw conversion.Hub) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we cannot change ConvertTo and ConvertFrom func's signature. It will break the webhook
@nitishchauhan0022 would you revert the change in the webhook part. I think it changes the func signature and makes webhook unable to start. I think we can skip webhook in this PR. Thanks! |
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
/approve Thanks for your contribution! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nitishchauhan0022, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6e0937e
into
open-cluster-management-io:main
@qiujian16 Thanks for the merge, i will open the prs for the remaining components this week. |
Summary
Adding contextual logging
Related issue(s)
Fixes #191
For More Info:
https://www.kubernetes.dev/blog/2022/05/25/contextual-logging/
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md