Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ enable addon management feature gate by default #222

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Jul 14, 2023

Summary

Enable the addon management feature gate by default for:

  • clusterManager, will install the addon-manager component, if you want disable:
apiVersion: operator.open-cluster-management.io/v1
kind: ClusterManager
metadata:
  name: cluster-manager
spec:
...
  addOnManagerConfiguration:
    featureGates:
    - feature: AddonManagement
      mode: Disable
  • klusterlet, will enable the addon management feature for the registration-agent, if you want to disable:
apiVersion: operator.open-cluster-management.io/v1
kind: Klusterlet
metadata:
  name: klusterlet
spec:
...
  registrationConfiguration:
    featureGates:
    - feature: AddonManagement
      mode: Disable

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from deads2k and jnpacker July 14, 2023 03:11
@qiujian16
Copy link
Member

I think we also enable this feature gate manually in some tests, should we also remove those codes?

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (f7cd140) 60.28% compared to head (1061bf6) 60.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
- Coverage   60.28%   60.24%   -0.05%     
==========================================
  Files         130      130              
  Lines       13494    13494              
==========================================
- Hits         8135     8129       -6     
- Misses       4609     4613       +4     
- Partials      750      752       +2     
Flag Coverage Δ
unit 60.24% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhujian7 zhujian7 force-pushed the enable-addon-management branch 4 times, most recently from 61ed98f to d8c5db3 Compare July 14, 2023 06:43
Signed-off-by: zhujian <jiazhu@redhat.com>
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9ff0948 into open-cluster-management-io:main Jul 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants