Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Build a commonoption for all managers #228

Merged

Conversation

qiujian16
Copy link
Member

Summary

so we can set leader and qps related setting for all controllers

Related issue(s)

Fixes #

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@openshift-ci openshift-ci bot requested review from deads2k and jnpacker July 24, 2023 01:56
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 72.93% and project coverage change: +0.06% 🎉

Comparison is base (8d974c2) 60.22% compared to head (2870400) 60.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   60.22%   60.29%   +0.06%     
==========================================
  Files         130      131       +1     
  Lines       13502    13543      +41     
==========================================
+ Hits         8132     8166      +34     
- Misses       4619     4624       +5     
- Partials      751      753       +2     
Flag Coverage Δ
unit 60.29% <72.93%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/common/options/agent.go 66.66% <66.66%> (ø)
pkg/common/options/options.go 100.00% <100.00%> (+32.40%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@qiujian16
Copy link
Member Author

/assign @skeeey

@skeeey
Copy link
Member

skeeey commented Jul 25, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit e22faa4 into open-cluster-management-io:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants