Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Refactor code to start managers with shared informers #232

Conversation

qiujian16
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from elgnay and skeeey July 25, 2023 07:52
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member Author

/assign @skeeey

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.07% ⚠️

Comparison is base (fb6ce75) 60.44% compared to head (101c733) 60.37%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   60.44%   60.37%   -0.07%     
==========================================
  Files         132      132              
  Lines       13669    13658      -11     
==========================================
- Hits         8262     8246      -16     
- Misses       4651     4653       +2     
- Partials      756      759       +3     
Flag Coverage Δ
unit 60.37% <33.33%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/work/webhook/v1/manifestwork_validating.go 70.51% <0.00%> (ø)
pkg/common/options/options.go 85.29% <28.57%> (-14.71%) ⬇️
...registration/webhook/v1/managedcluster_mutating.go 77.92% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@skeeey
Copy link
Member

skeeey commented Aug 21, 2023

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants